add dbxrefs to NISO URLs #131
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijane
reviewed
Aug 15, 2022
There was a problem hiding this comment.
I have thoughts.
- I think we should use IAO_0000119 and not hasDbXref, because we're already using hasDbXref for the unique ID numbers for each CrediT term. (I imagine these numbers haven't changed, but we might double-check the new NISO pages to be sure.)
- We definitely should remove references to casrai.org.
- If we edit the main CRO OWL file directly like this, we're effectively abandoning the ODK-based process we created this ontology with. Recall that we did our own OWL implementation of CrediT at https://github.com/data2health/credit-ontology and created an imports file to pull in those definitions. Technically, we should update that ontology and re-do the imports. That said, I have no idea how difficult that might be, given that the ODK and it supporting tools like ROBOT have changed a lot since we last used them.
- Even if we abandon the ODK for CRO, we should probably update credit-ontology too. Maybe we should ask VincentML about this in their ticket.
|
action items:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #130
@marijane I added the NISO URLs as hasDbxref
The casrai links are dead, should we just delete those? And let me know if you think the NISO links should be definition sources instead of dbxrefs (or in addition to?)
cc @kristiholmes @mellybelly